-
Notifications
You must be signed in to change notification settings - Fork 471
Fix bug with options not being copied correctly #794
Conversation
f1d24ab to
75a1147
Compare
Fixes sass/sassc#88 Add more assertions for invalid context options
75a1147 to
fa22282
Compare
|
Appveyor seems to cache the sassc commit it uses somehow when I just ammend the message: |
|
OK, facepalm to myself. Appveyor.yml still contained the url to my local sassc branch ... |
|
@mgreter, if you are authorized, you would see a Stop Build (or Skip Build) button on Appveyor. So you can stop these for example: https://ci.appveyor.com/project/hcatlin/libsass/build/1.0.50 |
|
Nope, no permission to do that, already checked 😉 Also @hcatlin probably needs to delete his "hcatlin" repo on appveyor so the now setup official one kicks in (hopefully)! |
|
Oh great! On a separate note @xzyfer and I were just chatting here https://gitter.im/sass/~chat# about something which you might be able to help us with! Whenever you have time, you can see. The chat logs don't expire on gitter. 😃 |
|
@mgreter you can rebase out your commits and rebase of master instead to get those commits |
|
This appears to be fixed in my tests 👍 |
|
@mgreter, apparently we have access to start/stop here: https://ci.appveyor.com/project/sass/libsass/build/1.0.2. I have started the build! 👌 |
|
I have access to change the webhook. Do you know the correct webhook URL? I can't find anything in the appveyor ui. |
|
@xzyfer https://ci.appveyor.com/api/github/webhook?id=s88o0u5qra2ng4vy |
|
OK updated! |
|
Wow 1hr AppVeyor builds is a serious problem 👎 |
|
LOL yeah. Some loop in there. I think unless there is a new commit pushed (or rebased/amend the existing one), it will not pick up sass/libsass ? |
|
Oh wow I just realised that's not even this branch 😭 |
Fix bug with options not being copied correctly
|
@am11 it appear altering that webhook url has broken our AppVeyor integration. Where did you find the that webhook URL in the AppVeyor interface? |
|
@xzyfer, seems like it is building the latest release: https://ci.appveyor.com/project/sass/libsass/. |
|
Hmm I don't appear to have access. It's building the releases but not pinging back to github and showing up in PRs. |
|
I think if you are an admin in Sass, then it should allow you to access and modify settings. You can perhaps try deleting the entry and creating a new one with https://ci.appveyor.com/api/github/webhook?id=s88o0u5qra2ng4vy. |
|
I just checked and the settings for libsass webhooks seem to match this. Is there anything you need me to do as an admin? |
|
@hcatlin can you please add myself and mgreter to the github sass team so
|
|
From gitter chat with @am11
|
|
@xzyfer I added you and @mgreter to this team: https://github.com/orgs/sass/teams/node-sass-owners, hopefully that will sort it, you should get an email about it. |
|
Aha, success! Thanks @andrew it appear to have access now. |
|
👍 🎉 |



This is one part of a fix for sass/sassc#88
Sassc related PR: sass/sassc#89
Also adds more assertions for invalid context options!